Avoid potential ambiguities for [h/v/hv]cat in packages
#41511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Friendly bump [I need this! :-)] |
|
I do too 🙂 |
Contributor
|
This would be very helpful for me too. See my last succesfull tests with DescriptorSystems with Julia 1.6 and the 174 failed tests with Julia 1.7 due to the |
Member
|
Seems like this would be useful to people and is unlikely to have any real issues so I would say to just merge this. |
Member
Author
DilumAluthge
removed
the
merge me
Member
|
On a separate note, I restarted the two failing CI jobs, just so we can see if CI passes on this PR. |
Member
DilumAluthge
removed
the
merge me
Member
|
If this PR resolves the problem, I'm happy, but if anybody knows a remaining reason to revert #41394 speak up. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41394 has changed the method signature in concatenation functions involving
UniformScalings. This triggers method ambiguities for matrix-related packages, includingLinearMaps.jl(see JuliaLinearAlgebra/LinearMaps.jl#158). This PR resolves the ambiguity at the root.Closes JuliaLinearAlgebra/LinearMaps.jl#158.